Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Text hidden behind checkbox in the "change due calculator" screen #12808

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

samiuelson
Copy link
Collaborator

@samiuelson samiuelson commented Oct 22, 2024

Fix for UI glitch in "Change due calculator" screen

Closes: #12662

Description

This PR fixes UI issue in "Change due calculator" screen–the label was overlapping with the checkbox certain scenarios (locales/screen widhts):
Screenshot 2024-10-22 at 13 39 11
The bug was caused by the Row's horizontalAlignment setting.

Steps to reproduce

To reproduce the bug, modify the string length or adjust screen width and observe the checkbox overlapping the text as shown in the screenshot above.

Testing information

Tested on Google Pixel 7 Pro, Android 14 and in Compose previews of various screen sizes and orientations.

The tests that have been performed

  1. Reproduced the original issue by adjusting the text of the label
  2. Verified that updated horizontal alignment settings fix the issue on various screen sizes

Images/gif

After

Screenshot 2024-10-22 at 13 23 41 Screenshot 2024-10-22 at 13 23 26
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@samiuelson samiuelson linked an issue Oct 22, 2024 that may be closed by this pull request
@samiuelson samiuelson added this to the 21.0 milestone Oct 22, 2024
@samiuelson samiuelson added type: bug A confirmed bug. feature: mobile payments Related to mobile payments / card present payments / Woo Payments. labels Oct 22, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitb98ed73
Direct Downloadwoocommerce-wear-prototype-build-pr12808-b98ed73.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 22, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitb98ed73
Direct Downloadwoocommerce-prototype-build-pr12808-b98ed73.apk

@samiuelson samiuelson marked this pull request as ready for review October 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: mobile payments Related to mobile payments / card present payments / Woo Payments. type: bug A confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text cut off in the "Get paid" screen when the text is long.
2 participants